-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More sensible defaults for webhook environment variables #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kispaljr
changed the title
More sensible default for webhook environment variables
More sensible defaults for webhook environment variables
Aug 22, 2024
/retest |
/retest |
kispaljr
requested review from
liamfallon and
efiacor
and removed request for
s3wong
August 23, 2024 06:01
efiacor
reviewed
Aug 27, 2024
nagygergo
reviewed
Aug 28, 2024
/retest |
2 similar comments
/retest |
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: efiacor, kispaljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove hardwired string literals as the default values of WEBHOOK_SERVICE_NAME and WEBHOOK_SERVICE_NAMESPACE environment variables.
This PR introduces the following changes in behavior:
The value of WEBHOOK_SERVICE_NAME is determined by one of the followings (in precedence order):
APIService
object namedv1alpha1.porch.kpt.dev
The value of WEBHOOK_SERVICE_NAMESPACE is determined by one of the followings (in precedence order):
APIService
object namedv1alpha1.porch.kpt.dev