Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare adding end-to-end tests to the controller go module #97

Merged
merged 11 commits into from
Sep 4, 2024

Conversation

kispaljr
Copy link
Collaborator

@kispaljr kispaljr commented Aug 27, 2024

This PR contains the following end-to-end testing related changes:

  • Export end-to-end TestSuite methods as public in order to be usable from other go modules in the future (notable from the porch/controller go module)
  • Fix a bug in make run-in-kind that prevented some docker bulid errors to properly propagated to the root make process
  • Force the reload of the newly built porch-server and/or porch-controllers pods during make run-in-kind
  • test/e2e/cli now explicitly tests the porchctl binary in the .build directory of the current git tree (as opposed to the first one found in PATH)
  • Hopefully make the TestFunctionRepository test case less flaky by changing a fix delay to a more flexible wait cycle
  • pin the version of the kpt-functions-sdk/go/fn module to prevent future dependency updates to break the code of the imported kpt functions that unfortunately use (the pinned) ancient incompatible version of the SDK

@kispaljr
Copy link
Collaborator Author

/retest

Makefile Show resolved Hide resolved
go.mod Show resolved Hide resolved
test/e2e/suit_utils.go Outdated Show resolved Hide resolved
@kispaljr
Copy link
Collaborator Author

/retest

1 similar comment
@kispaljr
Copy link
Collaborator Author

/retest

@kispaljr
Copy link
Collaborator Author

/retest

2 similar comments
@kispaljr
Copy link
Collaborator Author

/retest

@kispaljr
Copy link
Collaborator Author

/retest

Copy link
Member

@liamfallon liamfallon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@liamfallon
Copy link
Member

/test presubmit-nephio-go-test

@kispaljr
Copy link
Collaborator Author

kispaljr commented Sep 4, 2024

/retest

@liamfallon
Copy link
Member

/lgtm

@nephio-prow nephio-prow bot added the lgtm label Sep 4, 2024
@liamfallon
Copy link
Member

/approve
/lgtm

Copy link
Contributor

nephio-prow bot commented Sep 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kispaljr, liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@efiacor efiacor merged commit b81a03e into nephio-project:main Sep 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants