Check for normalized quats. #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jb-ye
reviewed
Apr 1, 2024
| @@ -57,6 +57,7 @@ def project_gaussians( | |||
| - **cov3d** (Tensor): 3D covariances. | |||
| """ | |||
| assert block_width > 1 and block_width <= 16, "block_width must be between 2 and 16" | |||
| assert (quats.norm(dim=-1) - 1 < 1e-6).all(), "quats must be normalized" | |||
There was a problem hiding this comment.
Likely minor, but are there performance concerns here? This seems ~equivalent to a torch.cuda.synchronize() call.
jb-ye
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #152 (comment) it seems like the quaternions should always be normalized because the back-propagate gradient implementation in cuda doesn't account the normalization step.
This PR adds a check for that.
Tagging @jb-ye .