Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a guidance for installing gsplat on Windows #213

Merged
merged 7 commits into from
Jun 10, 2024
Merged

Added a guidance for installing gsplat on Windows #213

merged 7 commits into from
Jun 10, 2024

Conversation

KevinXu02
Copy link
Contributor

No description provided.

liruilong940607
liruilong940607 requested changes Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@liruilong940607 liruilong940607 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice! Maybe move this instruction to a standalone file, e.g., docs/INSTALL_WIN.md, and only put a pointer in README?

I personally prefer this way to avoid overwhelming information in the readme

@KevinXu02
Copy link
Contributor Author

This is nice! Maybe move this instruction to a standalone file, e.g., docs/INSTALL_WIN.md, and only put a pointer in README?

I personally prefer this way to avoid overwhelming information in the readme

Updated. Thanks for the advice!

liruilong940607
liruilong940607 approved these changes Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@liruilong940607 liruilong940607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@liruilong940607 liruilong940607 merged commit 1f067b4 into nerfstudio-project:main Jun 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liruilong940607 liruilong940607 liruilong940607 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KevinXu02 @liruilong940607