[DRAFT] gsplat refactor #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
incredible! man! |
liruilong940607
added a commit
that referenced
this pull request
Jul 17, 2024
* [DRAFT] gsplat refactor (#269) * initial commit, rough design of modules * moved strategy.py into gsplat dir * latest commit for 1:1 meeting * removed ops, losses, and strategies now inherit from an abstract 'Strategy' class * GSs init handled in private method * format * class Gaussian3D * WIP: _strategy * simple_trainer no longer uses Gaussians object and instead uses ParameterDict with newly-added 'activations' dict * simple_trainer no longer uses Gaussians object and instead uses ParameterDict with newly-added 'activations' dict * created mcmc and revised strategy, simplified training scripts * update _strategy * minor * implemented ruilongs' suggested changes, no longer using separate class for revised ADS heuristics * added docstrings, removed overriding activations attribute, fixed device argument passing * mcmc and default are all trainable * cleanup * minor * minor * minor * minor * hardcode activations into strategy * minor cleanup * minor * seperate the strategy in to individual files * change optimizers from List to Dict * switch to dataclass * stateless strategy * minor cleanup * revised_opacity * _update_param_with_optimizer * individual ops * means3d -> means * starting docs * docs * docs * docs * docs * docs * minor fix to pass test * move BINOMS to strategy state * nits * nit fix * viewcode * relocation func cleanup * nits in docs * cleanup imports * minor cleanup * support screen size pruning / splitting --------- Co-authored-by: Ryan Tabrizi <[email protected]> Co-authored-by: Ruilong Li <[email protected]> Co-authored-by: rtabrizi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ongoing branch of changes for the gsplat modularization/refactor