Make download script work on Windows, too #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Recent versions of Windows 10 don't have `wget` but do have `curl`, so now we can download files across the major platforms. 2. Windows 10 also doesn't have the `unzip` program, but a version of `tar` (apparently bsdtar), which supports `.zip` files (unlike the GNU tar on the Linux box I tested on). So need to use different code paths depending on platform. Tested on Windows 10 22H2 and Linux.
liruilong940607
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wgetbut do havecurl, so now we can download files across the major platforms.unzipprogram, but a version oftar(apparently bsdtar), which supports.zipfiles (unlike the GNU tar on the Linux box I tested on). So need to use different code paths depending on platform.Tested on Windows 10 22H2 and Linux.