Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support generic TDataset in paralleldatamanager #2884

Merged
merged 4 commits into from
Feb 8, 2024
Merged

support generic TDataset in paralleldatamanager #2884

merged 4 commits into from
Feb 8, 2024

Conversation

hturki
Copy link
Contributor

@hturki hturki commented Feb 7, 2024

As it stands one cannot use a custom Dataset class in ParallelDatamanager. This handles that usecase in the same manner as VanillaDataManager and FullImagesDataManager

brentyi
brentyi approved these changes Feb 8, 2024
View reviewed changes
Copy link
Collaborator

@brentyi brentyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable to me!

@brentyi brentyi merged commit 1d070f5 into nerfstudio-project:main Feb 8, 2024
2 checks passed
@hturki hturki deleted the ht/parallel-generic branch February 8, 2024 00:51
ArpegorPSGH pushed a commit to ArpegorPSGH/nerfstudio that referenced this pull request Jun 22, 2024
@hturki @ArpegorPSGH
support generic TDataset in paralleldatamanager (nerfstudio-project#2884
453b4ce 
)

* support generic TDataset in paralleldatamanager

* run black

* run ruff

* run ruff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentyi brentyi brentyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hturki @brentyi