Bump viser #3234
Merged
Bump viser #3234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentyi
reviewed
Jun 16, 2024
| @@ -44,7 +44,7 @@ def __init__( | |||
| ): | |||
| super().__init__() | |||
|
|
|||
| self._ws_server = viser.infra.Server(host, port, http_server_root=None, verbose=False) | |||
| self._ws_server = ViserServer(host, port, http_server_root=None, verbose=False) | |||
There was a problem hiding this comment.
sorry, I think this is now renamed to: https://viser.studio/latest/infrastructure/#viser.infra.WebsockServer
There was a problem hiding this comment.
change is made
pyproject.toml
Outdated
| @@ -57,7 +57,7 @@ dependencies = [ | |||
| "torchvision>=0.14.1", | |||
| "torchmetrics[image]>=1.0.1", | |||
| "typing_extensions>=4.4.0", | |||
| "viser==0.1.27", | |||
| "viser==0.2.1", | |||
There was a problem hiding this comment.
maybe we can actually bump to 0.2.2 once nerfstudio-project/viser#223 is merged, since that resolves some unlikely but plausible race conditions in the messaging infra!
|
Yeah I think we can go ahead with the bump as soon as these fixes are merged + we do a viser release, otherwise we have some regressions: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Viser api changes and bump version to 0.2.1