Speed up PairPixelSampler #3452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure about the test failure: |
nepfaff
changed the title
|
|
||
| unique_vals = torch.unique(tensor) | ||
| if any(val not in (0, 1) for val in unique_vals) or tensor.dtype != torch.float32: | ||
| if not (tensor.dtype == torch.float32 and torch.all((tensor == 0) | (tensor == 1))): |
There was a problem hiding this comment.
Sweet, this is so much cleaner
akristoffersen
approved these changes
Sep 30, 2024
nepfaff
force-pushed
the
rejection_sample_mask_for_pair_sampler
branch
from
a24cd94
to
c153976
Compare
There is no reason, and it is a drop-in replacement. However, I agree that a separate PR seems better here. I opened one here (rebased this branch and started the new PR from it). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speeds up the extremely slow
PairPixelSampler. The main issue seems to be with mask erosion being slow. I managed to speed it up a bit but it still isn't great. I also added the functionality from #2585 toPairPixelSampler.Before any of the changes:
With only erosion:
With both erosion and rejection sampling:
This is an initial step towards #3446