Faster icons

pyproject.toml

@@ -70,7 +70,7 @@ examples = [
 # installation via the Git URL, because build artifacts aren't
 # version-controlled.
 [tool.setuptools.package-data]
-viser = ["py.typed", "*.pyi", "_icons/tabler-icons.tar", "client/**/*", "client/**/.*"]
+viser = ["py.typed", "*.pyi", "_icons/tabler-icons.zip", "client/**/*", "client/**/.*"]
 # </>
 
 [tool.setuptools.exclude-package-data]

src/viser/_icons.py

@@ -1,20 +1,21 @@
-import tarfile
+import zipfile
+from functools import lru_cache
 from pathlib import Path
 
 from ._icons_enum import IconName
 
 ICONS_DIR = Path(__file__).absolute().parent / "_icons"
 
 
+@lru_cache(maxsize=32)
 def svg_from_icon(icon_name: IconName) -> str:
     """Read an icon and return it as a UTF string; we expect this to be an
     <svg /> tag."""
     assert isinstance(icon_name, str)
-    icons_tarball = ICONS_DIR / "tabler-icons.tar"
+    icons_zipfile = ICONS_DIR / "tabler-icons.zip"
 
-    with tarfile.open(icons_tarball) as tar:
-        icon_file = tar.extractfile(f"{icon_name}.svg")
-        assert icon_file is not None
-        out = icon_file.read()
+    with zipfile.ZipFile(icons_zipfile) as zip_file:
+        with zip_file.open(f"{icon_name}.svg") as icon_file:
+            out = icon_file.read()
 
     return out.decode("utf-8")

src/viser/_icons_generate_enum.py

@@ -1,6 +1,6 @@
 """Helper script for dumping Tabler icon names into a Literal type."""
 
-import tarfile
+import zipfile
 from pathlib import Path
 
 HERE_DIR = Path(__file__).absolute().parent
@@ -17,8 +17,10 @@ def enum_name_from_icon(name: str) -> str:
 
 
 if __name__ == "__main__":
-    with tarfile.open(ICON_DIR / "tabler-icons.tar") as tar:
-        icon_names = sorted([name.partition(".svg")[0] for name in tar.getnames()])
+    with zipfile.ZipFile(ICON_DIR / "tabler-icons.zip") as zip_file:
+        icon_names = sorted(
+            [Path(name).stem for name in zip_file.namelist() if name.endswith(".svg")]
+        )
 
     # Generate stub file. This is used by type checkers.
     (HERE_DIR / "_icons_enum.pyi").write_text(