Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let the Livebook update banner show Nerves Livebook updates instead of regular Livebook updates #236

Open
PhillippOhlandt opened this issue Jul 9, 2022 · 7 comments

Comments

@PhillippOhlandt
Copy link

When the regular Livebook got a new release, the update banner in Nerves Livebook gets triggered.

Since Livebook and Nerves Livebook don't have matching version numbers and release dates, this is misleading and confusing.

The update check happens in this GenServer:
https://github.com/livebook-dev/livebook/blob/main/lib/livebook/update_check.ex

A simple solution would be to make the github release url and the application name configurable using application config so that Nerves Livebook can set its own values.

@fhunleth pointed out that it would also be nice if the user can interact with the update banner to trigger a firmware update.

@a-maze-d
Copy link

I have raised both an idea and a PR against livebook. This should allow to make this configurable.

It does not solve the second part of the issue, to allow interaction with the banner, but it's at least a start :-) We can move the interaction aspect to a separate issue (should we be able to resolve the first aspect)

@a-maze-d
Copy link

Good news, the PR has been approved and been merged in. Not sure it will find it's way into livebook v0.14 (probably to close to releasing), but at least we should be able to solve the problem as from v0.15 :-)

@fhunleth
Copy link
Contributor

Wow, thank you!

@a-maze-d
Copy link

My changes made it onto the 0.14 branch. So next upgrade should allow us to make the changes

@fhunleth
Copy link
Contributor

@a-maze-d Congratulations on getting that PR into Livebook! This is going to be a really nice improvement.

@a-maze-d
Copy link

Yes, the idea was great, and I wanted to raise a PR against nerves_livebook, but it turned out that the app_version (in livebook) is hardcoded and can't be overwritten :-(

I have now raised a second PR against livebook to get that fixed too 😄

@a-maze-d
Copy link

Second PR went in... so now we need a bit more and I can raise a PR once the new version is out. I have a hacked version and it's looking good :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants