Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend configuration for update check to include version #2780

Merged
merged 6 commits into from
Sep 18, 2024

Conversation

a-maze-d
Copy link
Contributor

The Livebook.Config.app_version/0 is hard coded and can't be changed. This hard coded version corresponds more to the library version and not to the app version (and therefore can't be overwritten).

This PR introduces that distinction by introducing a new Livebook.Config.livebook_version/0 function and make the Livebook.Config.app_version/0 overwritable through config/config.exs.

You can find a more information here

Copy link

github-actions bot commented Sep 15, 2024

Uffizzi Preview deployment-56291 was deleted.

@josevalim
Copy link
Contributor

In this case I would prefer then to change the URL configuration to be a tuple, so it holds both the version and the URL. For everything else we keep the version as is, otherwise it can lead to confusion (for example, someone reports a bug for LV 0.13 but it is actually the nerves Livebook version and so on).

@a-maze-d
Copy link
Contributor Author

a-maze-d commented Sep 15, 2024

That make sense, but we don't have a URL, so I guess you mean the github_release_repo. Should we change it to a github_release_repo_and_version. Not 100% happy with that. Let me give it some more thoughts.

@josevalim
Copy link
Contributor

Yes, we can call it github_release_info.

Changed the github_release_repo into a github_release_info which contains both the repo as well as the version.
Reverted back the previous changes that introduced livebook_version
@a-maze-d
Copy link
Contributor Author

I reverted my previous commit and followed your recommendation. What do you think?

@a-maze-d
Copy link
Contributor Author

I did run the tests locally and they do pass (but they do seem to be flaky 😞 and I have to run them several times. I guess that's the reason why the GH action failed.

config/config.exs Outdated Show resolved Hide resolved
@jonatanklosko jonatanklosko changed the title Distinguish between the Livebook app and library version (idea 2742, second part) Extend configuration for update check to include version Sep 18, 2024
@jonatanklosko jonatanklosko merged commit 7ec3976 into livebook-dev:main Sep 18, 2024
6 checks passed
jonatanklosko added a commit that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants