-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend configuration for update check to include version #2780
Conversation
Uffizzi Preview |
In this case I would prefer then to change the URL configuration to be a tuple, so it holds both the version and the URL. For everything else we keep the version as is, otherwise it can lead to confusion (for example, someone reports a bug for LV 0.13 but it is actually the nerves Livebook version and so on). |
That make sense, but we don't have a URL, so I guess you mean the |
Yes, we can call it github_release_info. |
Changed the github_release_repo into a github_release_info which contains both the repo as well as the version. Reverted back the previous changes that introduced livebook_version
I reverted my previous commit and followed your recommendation. What do you think? |
I did run the tests locally and they do pass (but they do seem to be flaky 😞 and I have to run them several times. I guess that's the reason why the GH action failed. |
Co-authored-by: José Valim <[email protected]> Co-authored-by: Jonatan Kłosko <[email protected]>
The
Livebook.Config.app_version/0
is hard coded and can't be changed. This hard coded version corresponds more to the library version and not to the app version (and therefore can't be overwritten).This PR introduces that distinction by introducing a new
Livebook.Config.livebook_version/0
function and make theLivebook.Config.app_version/0
overwritable throughconfig/config.exs
.You can find a more information here