chore: early return on calculate tx fee (#337)

chore: early return on calculate tx fee
nervosnetwork · Aug 9, 2019 · f9af078 · f9af078
2 parents 454fd55 + 8a8f15d
commit f9af078
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/app/models/ckb_sync/node_data_processor.rb b/app/models/ckb_sync/node_data_processor.rb
@@ -300,6 +300,7 @@ def update_address_balance_and_ckb_transactions_count(address)
 
     def calculate_tx_fee(local_block)
       ckb_transactions = local_block.ckb_transactions.where(is_cellbase: false)
+      return if ckb_transactions.blank?
 
       ApplicationRecord.transaction do
         ckb_transactions.each(&method(:update_transaction_fee))

diff --git a/test/models/ckb_sync/node_data_processor_test.rb b/test/models/ckb_sync/node_data_processor_test.rb
@@ -615,7 +615,7 @@ class NodeDataProcessorTest < ActiveSupport::TestCase
 
         block = Block.last
         cellbase = Cellbase.new(block)
-        expected_cellbase_display_outputs = block.cellbase.cell_outputs.map { |cell_output| { id: cell_output.id, capacity: cell_output.capacity, address_hash: cell_output.address_hash, target_block_number: cellbase.target_block_number, base_reward: cellbase.base_reward, commit_reward: cellbase.commit_reward, proposal_reward: cellbase.proposal_reward, secondary_reward: cellbase.secondary_reward } }
+        expected_cellbase_display_outputs = block.cellbase.cell_outputs.order(:id).map { |cell_output| { id: cell_output.id, capacity: cell_output.capacity, address_hash: cell_output.address_hash, target_block_number: cellbase.target_block_number, base_reward: cellbase.base_reward, commit_reward: cellbase.commit_reward, proposal_reward: cellbase.proposal_reward, secondary_reward: cellbase.secondary_reward } }
 
         assert_equal expected_cellbase_display_outputs, block.cellbase.display_outputs
       end