Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate websocket client into rails side #1282

Merged
merged 23 commits into from
May 29, 2023

Conversation

ShiningRay
Copy link
Contributor

And remove the usage of PoolTransactionEntry, instead using CkbTransaction.tx_pending.

@ShiningRay ShiningRay marked this pull request as draft May 18, 2023 14:32
@codecov-commenter
Copy link

codecov-commenter commented May 18, 2023

Codecov Report

Patch coverage: 37.13% and project coverage change: -1.64 ⚠️

Comparison is base (92915ff) 60.25% compared to head (7876698) 58.62%.

❗ Current head 7876698 differs from pull request most recent head a15a626. Consider uploading reports for the commit a15a626 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1282      +/-   ##
===========================================
- Coverage    60.25%   58.62%   -1.64%     
===========================================
  Files          267      267              
  Lines         7579     7103     -476     
===========================================
- Hits          4567     4164     -403     
+ Misses        3012     2939      -73     
Impacted Files Coverage Δ
app/controllers/api/v2/transactions_controller.rb 0.00% <0.00%> (ø)
app/models/cell_datum.rb 0.00% <ø> (ø)
app/models/deployed_cell.rb 10.52% <0.00%> (-61.85%) ⬇️
app/models/rolling_avg_block_time.rb 0.00% <0.00%> (ø)
...orkers/address_unclaimed_compensation_generator.rb 0.00% <0.00%> (ø)
app/workers/flush_inputs_outputs_cache_worker.rb 0.00% <0.00%> (-100.00%) ⬇️
app/workers/pool_transaction_check_worker.rb 0.00% <0.00%> (-29.17%) ⬇️
lib/scheduler.rb 0.00% <0.00%> (ø)
lib/tasks/migration/fill_nrc_721_token.rake 7.35% <0.00%> (-0.46%) ⬇️
lib/websocket.rb 0.00% <0.00%> (ø)
... and 22 more

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ShiningRay ShiningRay marked this pull request as ready for review May 25, 2023 13:10
@ShiningRay ShiningRay force-pushed the feat/websocket branch 2 times, most recently from 08127c7 to cd0a311 Compare May 25, 2023 16:19
app/jobs/commit_block_job.rb Show resolved Hide resolved
app/models/ckb_transaction.rb Outdated Show resolved Hide resolved
app/models/pool_transaction_entry.rb Outdated Show resolved Hide resolved
app/jobs/import_block_job.rb Show resolved Hide resolved
@Keith-CY Keith-CY requested a review from iamyates May 26, 2023 02:00
* develop:
  implement download csv (nervosnetwork#1241)
  fix cache deletion
  Deploy to testnet (nervosnetwork#1286)

# Conflicts:
#	app/models/address.rb
#	app/models/ckb_sync/node_data_processor.rb
@ShiningRay ShiningRay added this pull request to the merge queue May 29, 2023
Merged via the queue into nervosnetwork:develop with commit c116e9e May 29, 2023
@ShiningRay ShiningRay deleted the feat/websocket branch May 29, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants