Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2023 05 04 sort nft collections by hot new #1294

Conversation

iamyates
Copy link
Contributor

@iamyates
Copy link
Contributor Author

  1. changed the order implementation
  2. used lib/scheduler.rb

@iamyates
Copy link
Contributor Author

@ShiningRay ready for review

@codecov-commenter
Copy link

codecov-commenter commented May 29, 2023

Codecov Report

Patch coverage: 46.71% and project coverage change: +5.76 🎉

Comparison is base (92915ff) 60.25% compared to head (bfcad7a) 66.02%.

❗ Current head bfcad7a differs from pull request most recent head 943bd95. Consider uploading reports for the commit 943bd95 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1294      +/-   ##
===========================================
+ Coverage    60.25%   66.02%   +5.76%     
===========================================
  Files          267      268       +1     
  Lines         7579     7117     -462     
===========================================
+ Hits          4567     4699     +132     
+ Misses        3012     2418     -594     
Impacted Files Coverage Δ
app/controllers/api/v2/transactions_controller.rb 0.00% <0.00%> (ø)
app/models/cell_datum.rb 0.00% <ø> (ø)
app/models/deployed_cell.rb 72.36% <0.00%> (ø)
app/models/rolling_avg_block_time.rb 0.00% <0.00%> (ø)
...orkers/address_unclaimed_compensation_generator.rb 0.00% <0.00%> (ø)
...pdate_h24_ckb_transactions_count_on_udts_worker.rb 0.00% <0.00%> (ø)
lib/scheduler.rb 0.00% <0.00%> (ø)
lib/tasks/migration/fill_nrc_721_token.rake 7.35% <0.00%> (-0.46%) ⬇️
lib/websocket.rb 0.00% <0.00%> (ø)
lib/tasks/migration/register_udt.rake 17.17% <11.62%> (ø)
... and 28 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@iamyates iamyates self-assigned this May 31, 2023
@iamyates iamyates added this pull request to the merge queue May 31, 2023
Merged via the queue into nervosnetwork:develop with commit 7853945 May 31, 2023
@iamyates iamyates deleted the 2023_05_04_sort_nft_collections_by_hot_new branch May 31, 2023 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants