Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2023 04 21 sort by field new #1295

Merged
merged 24 commits into from
May 30, 2023

Conversation

iamyates
Copy link
Contributor

@iamyates iamyates requested a review from ShiningRay May 29, 2023 02:10
@iamyates iamyates self-assigned this May 29, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 29, 2023

Codecov Report

Patch coverage: 47.84% and project coverage change: +0.21 🎉

Comparison is base (92915ff) 60.25% compared to head (60f0183) 60.47%.

❗ Current head 60f0183 differs from pull request most recent head 0dafd53. Consider uploading reports for the commit 0dafd53 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1295      +/-   ##
===========================================
+ Coverage    60.25%   60.47%   +0.21%     
===========================================
  Files          267      267              
  Lines         7579     7742     +163     
===========================================
+ Hits          4567     4682     +115     
- Misses        3012     3060      +48     
Impacted Files Coverage Δ
app/models/cell_input.rb 83.33% <0.00%> (ø)
app/models/ckb_sync/node_data_processor.rb 0.00% <0.00%> (ø)
app/models/deployed_cell.rb 72.36% <0.00%> (ø)
app/models/rolling_avg_block_time.rb 0.00% <0.00%> (ø)
lib/tasks/migration/fill_nrc_721_token.rake 7.35% <0.00%> (-0.46%) ⬇️
lib/tasks/migration/register_udt.rake 17.17% <11.62%> (ø)
app/models/cell_output.rb 74.40% <45.45%> (-3.19%) ⬇️
app/models/ckb_transaction.rb 79.78% <50.00%> (+2.65%) ⬆️
app/controllers/api/v1/udts_controller.rb 70.17% <54.05%> (-29.83%) ⬇️
...trollers/api/v1/address_transactions_controller.rb 84.37% <74.28%> (-12.40%) ⬇️
... and 12 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@iamyates iamyates added this pull request to the merge queue May 30, 2023
Merged via the queue into nervosnetwork:develop with commit 4d82348 May 30, 2023
@iamyates iamyates deleted the 2023_04_21_sort_by_field_new branch May 30, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants