Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only check ckb node in blocksyncer, poolsyncer #1310

Merged

Conversation

ShiningRay
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2023

Codecov Report

Patch coverage: 42.66% and project coverage change: +5.28 🎉

Comparison is base (92915ff) 60.25% compared to head (ad43b8c) 65.54%.

❗ Current head ad43b8c differs from pull request most recent head 208659b. Consider uploading reports for the commit 208659b to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1310      +/-   ##
===========================================
+ Coverage    60.25%   65.54%   +5.28%     
===========================================
  Files          267      272       +5     
  Lines         7579     7252     -327     
===========================================
+ Hits          4567     4753     +186     
+ Misses        3012     2499     -513     
Impacted Files Coverage Δ
.../controllers/api/v2/ckb_transactions_controller.rb 0.00% <0.00%> (ø)
app/models/cell_datum.rb 0.00% <ø> (ø)
app/models/deployed_cell.rb 72.36% <0.00%> (ø)
app/models/rolling_avg_block_time.rb 0.00% <0.00%> (ø)
...orkers/address_unclaimed_compensation_generator.rb 0.00% <0.00%> (ø)
...pdate_h24_ckb_transactions_count_on_udts_worker.rb 0.00% <0.00%> (ø)
lib/scheduler.rb 0.00% <0.00%> (ø)
lib/tasks/migration/fill_nrc_721_token.rake 7.35% <0.00%> (-0.46%) ⬇️
lib/websocket.rb 0.00% <0.00%> (ø)
lib/tasks/migration/register_udt.rake 17.17% <11.62%> (ø)
... and 32 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Keith-CY Keith-CY merged commit 7be8d69 into nervosnetwork:develop Jun 12, 2023
rabbitz pushed a commit to rabbitz/ckb-explorer that referenced this pull request Jun 16, 2023
rabbitz pushed a commit to rabbitz/ckb-explorer that referenced this pull request Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants