Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update cell outputs status #1352

Merged
merged 4 commits into from
Aug 1, 2023
Merged

feat: update cell outputs status #1352

merged 4 commits into from
Aug 1, 2023

Conversation

rabbitz
Copy link
Collaborator

@rabbitz rabbitz commented Aug 1, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2023 •
edited
Loading

Codecov Report

Patch coverage: 22.80% and project coverage change: -0.28% ⚠️

Comparison is base (bb447e4) 66.37% compared to head (a74f5f5) 66.09%.
Report is 2 commits behind head on develop.

❗ Current head a74f5f5 differs from pull request most recent head 5a1a312. Consider uploading reports for the commit 5a1a312 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1352      +/-   ##
===========================================
- Coverage    66.37%   66.09%   -0.28%     
===========================================
  Files          275      276       +1     
  Lines         7397     7448      +51     
===========================================
+ Hits          4910     4923      +13     
- Misses        2487     2525      +38
Files Changed Coverage Δ
app/models/ckb_sync/new_node_data_processor.rb 94.76% <ø> (ø)
lib/websocket.rb 0.00% <0.00%> (ø)
...ib/tasks/migration/update_output_cells_status.rake 32.50% <32.50%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rabbitz rabbitz added this pull request to the merge queue Aug 1, 2023
Merged via the queue into nervosnetwork:develop with commit 5d88626 Aug 1, 2023
1 check passed
@rabbitz rabbitz deleted the fix/import_pending_transaction branch August 1, 2023 07:36
@rabbitz rabbitz mentioned this pull request Aug 1, 2023
Closed
zmcNotafraid pushed a commit to zmcNotafraid/ckb-explorer that referenced this pull request Aug 29, 2023
@rabbitz @zmcNotafraid
feat: update cell outputs status (nervosnetwork#1352)
35a62bb 
* fix: update output cell status

* feat: update cell outputs status

* chore: use find_each

* chore: log output cell id
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmcNotafraid zmcNotafraid zmcNotafraid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rabbitz @codecov-commenter @zmcNotafraid