Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: average block time missing data #695

Conversation

shaojunda
Copy link
Contributor

No description provided.

@shaojunda shaojunda requested a review from duanyytop July 17, 2020 08:00
@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2020

Codecov Report

Merging #695 into develop will increase coverage by 0.67%.
The diff coverage is 77.77%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #695      +/-   ##
===========================================
+ Coverage    88.60%   89.27%   +0.67%     
===========================================
  Files          121      121              
  Lines         3081     3069      -12     
===========================================
+ Hits          2730     2740      +10     
+ Misses         351      329      -22     
Impacted Files Coverage Δ
app/models/cell_output.rb 100.00% <ø> (ø)
.../workers/address_average_deposit_time_generator.rb 0.00% <0.00%> (ø)
...orkers/address_unclaimed_compensation_generator.rb 0.00% <0.00%> (ø)
...s/dao_contract_unclaimed_compensation_generator.rb 0.00% <0.00%> (ø)
...pp/controllers/api/v1/dao_depositors_controller.rb 100.00% <100.00%> (ø)
app/models/address.rb 100.00% <100.00%> (ø)
app/models/ckb_sync/node_data_processor.rb 99.16% <100.00%> (ø)
app/services/charts/daily_statistic_generator.rb 91.04% <100.00%> (+0.49%) ⬆️
app/utils/ckb_utils.rb 93.02% <100.00%> (ø)
app/utils/dao_compensation_calculator.rb 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e9a601...deea914. Read the comment docs.

@shaojunda shaojunda force-pushed the shaojunda-fix-average-block-time-missing-data branch from 9f07da0 to deea914 Compare July 17, 2020 08:31
@shaojunda shaojunda merged commit 04c905d into nervosnetwork:develop Jul 17, 2020
@shaojunda shaojunda deleted the shaojunda-fix-average-block-time-missing-data branch July 17, 2020 08:49
@shaojunda shaojunda mentioned this pull request Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants