feat: update SDK based on new verification model #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failed |
ashchan
changed the title
![nervos-bot[bot]](https://avatars.githubusercontent.com/in/22976?s=60&v=4){kind=small}
|
Is this going to |
That's the plan. |
classicalliu
approved these changes
May 28, 2019
|
BTW which is the upstream CKB pr on this change? |
Still working on it, ETA is this morning |
ashchan
changed the title
xxuejie
force-pushed
the
new-verification-model
branch
from
cba6a06
to
a16ab01
Compare
ashchan
approved these changes
Jun 4, 2019
ashchan
reviewed
Jun 4, 2019
| @@ -16,7 +16,7 @@ def initialize(host: CKB::RPC::DEFAULT_URL, mode: MODE::TESTNET) | |||
| @rpc = CKB::RPC.new(host: host) | |||
| if mode == MODE::TESTNET | |||
| # Testnet system script code_hash | |||
| expected_code_hash = "0x9e3b3557f11b2b3532ce352bfe8017e9fd11d154c4c7f9b7aaaa1e621b539a08" | |||
| expected_code_hash = "0xa4a3d87cd69733562865ddfaf12dd44cf4cd396c4128ff1a5839c2fe48b2a1a1" | |||
There was a problem hiding this comment.
This seems to be changing again on CKB rc/v0.14.0. Confirming that now.
https://github.com/nervosnetwork/ckb/pull/941/files#diff-346487b1ea6102562958846069e090deR9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please hold on merging this for now till the PR in CKB repo is merged, tho we can get review process started early.