fix: Only alter panic handler in riscv64 target #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the panic handler is inserted in all targets. This would make clippy complain about the following error: ``` error[E0152]: found duplicate lang item `panic_impl` ``` By only altering panic handler in riscv64 target, the error would now go away
xxuejie
force-pushed
the
only-alter-panic-handler-in-riscv64-target
branch
from
bc3b890
to
b91fa54
Compare
quake
approved these changes
Jan 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the panic handler is inserted in all targets. This would make clippy complain about the following error:
By only altering panic handler in riscv64 target, the error would now go away