Support new spawn #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuJiandong
requested changes
Sep 29, 2024
XuJiandong
requested changes
Sep 30, 2024
src/process_info.rs
Outdated
| PROCESS_CONTEXT_ID.with(|f| f.borrow().clone()) | ||
| } | ||
|
|
||
| pub fn inherited_fds(&self) -> Vec<Fd> { |
src/process_info.rs
Outdated
|
|
||
| pub fn wait(&self) { | ||
| let (lock, cvar) = &*self.data; | ||
| let mut event = lock.lock().unwrap(); |
There was a problem hiding this comment.
This name "event" is inconsistent: see notify.
XuJiandong
requested changes
Sep 30, 2024
src/spawn.rs
Outdated
| 0 | ||
| } | ||
|
|
||
| fn read(&self, fd: Fd, buf: *mut c_void, length: *mut usize) -> c_int { |
There was a problem hiding this comment.
If 100 bytes of data are written from one end of the pipe and the other end performs the following actions:
- Reads 30 bytes
- Reads 40 bytes
- Reads 30 bytes
The simulator is unable to handle this correctly.
mohanson
reviewed
Sep 30, 2024
src/global_data.rs
Outdated
| } | ||
| } | ||
| impl TxID { | ||
| fn next(&mut self) -> Self { |
There was a problem hiding this comment.
Why do you modify the original data here, but clone a copy of the data as the return value at the same time?
There was a problem hiding this comment.
In many places, the next step is HashMap::insert. This way, the return is more convenient to use.
To facilitate version switching of ckb-std during debugging, ckb-std-wrapper has been added in the tests as a dependency for ckb-std
* Dealing with read/write synchronization issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The simulator uses multithreading to simulate spawn, and each spawn will create a new thread.
After this change, need to use the matching ckb-std to use it in the CKB contract.
Modify