test: generated blocks in the connected state #1671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driftluo
force-pushed
the
diconnect-check-by-all-part
branch
from
a476541
to
8b433e5
Compare
driftluo
changed the title
u2
approved these changes
Oct 8, 2019
u2
approved these changes
Oct 8, 2019
keroro520
suggested changes
Oct 8, 2019
driftluo
force-pushed
the
diconnect-check-by-all-part
branch
from
8b433e5
to
1498d48
Compare
keroro520
approved these changes
Oct 8, 2019
quake
approved these changes
Oct 10, 2019
|
bors r=u2,keroro520,quake |
bors bot
added a commit
that referenced
this pull request
Oct 10, 2019
1664: chore: update get_block_template rpc doc r=quake,u2,keroro520,yangby-cryptape a=shaojunda replace difficulty with compact_target 1669: chore(test): Allow CI debug logs r=u2,zhangsoledad a=keroro520 The number of logs is acceptable after #1474. 1671: test: disconnect check by all part r=u2,keroro520,quake a=driftluo Disconnect check by all part 1673: docs: Update PoW mining algorithm description r=u2,quake a=ashchan Now that this has been decided the doc should reflect that before the next round of mining test. 1680: fix: get_block_transactions_process r=u2,quake a=zhangsoledad 1689: chore: issuance comment r=u2,quake a=zhangsoledad comments were lost on rebase 1690: ci: Make sure cargo-audit up-to-date r=quake,u2 a=zhangsoledad rustsec/rustsec#143 https://internals.rust-lang.org/t/idea-cargo-install-update/11072 rust-lang/cargo#6797 1691: chore: speed up maturity test r=u2,quake a=zhangsoledad Co-authored-by: shaojunda <[email protected]> Co-authored-by: keroro520 <[email protected]> Co-authored-by: driftluo <[email protected]> Co-authored-by: James Chen <[email protected]> Co-authored-by: zhangsoledad <[email protected]>
Build failed (retrying...)
|
bors bot
added a commit
that referenced
this pull request
Oct 10, 2019
1664: chore: update get_block_template rpc doc r=quake,u2,keroro520,yangby-cryptape a=shaojunda replace difficulty with compact_target 1669: chore(test): Allow CI debug logs r=u2,zhangsoledad a=keroro520 The number of logs is acceptable after #1474. 1671: test: disconnect check by all part r=u2,keroro520,quake a=driftluo Disconnect check by all part 1673: docs: Update PoW mining algorithm description r=u2,quake a=ashchan Now that this has been decided the doc should reflect that before the next round of mining test. Co-authored-by: shaojunda <[email protected]> Co-authored-by: keroro520 <[email protected]> Co-authored-by: driftluo <[email protected]> Co-authored-by: James Chen <[email protected]>
Build failed (retrying...)
|
bors bot
added a commit
that referenced
this pull request
Oct 10, 2019
1671: test: disconnect check by all part r=u2,keroro520,quake a=driftluo Disconnect check by all part 1673: docs: Update PoW mining algorithm description r=u2,quake a=ashchan Now that this has been decided the doc should reflect that before the next round of mining test. 1683: fix: Remove descendants of committed txs from pending pool r=quake,u2 a=keroro520 * fix(tx-pool): Remove descendants of committed txs from pending-pool * test(tx_pool): Add case of handling propose Co-authored-by: driftluo <[email protected]> Co-authored-by: James Chen <[email protected]> Co-authored-by: keroro520 <[email protected]>
Merge conflict (retrying...) |
bors bot
added a commit
that referenced
this pull request
Oct 10, 2019
1671: test: disconnect check by all part r=u2,keroro520,quake a=driftluo Disconnect check by all part Co-authored-by: driftluo <[email protected]>
Build failed
|
|
bors r=u2,keroro520,quake |
bors bot
added a commit
that referenced
this pull request
Oct 10, 2019
1671: test: disconnect check by all part r=u2,keroro520,quake a=driftluo Disconnect check by all part 1698: fix: WebAssembly build for core packages r=driftluo,zhangsoledad,u2 a=xxuejie Co-authored-by: driftluo <[email protected]> Co-authored-by: Xuejie Xiao <[email protected]>
Build failed (retrying...)
|
bors bot
added a commit
that referenced
this pull request
Oct 10, 2019
1671: test: disconnect check by all part r=u2,keroro520,quake a=driftluo Disconnect check by all part Co-authored-by: driftluo <[email protected]>
Build failed
|
|
bors r- |
driftluo
force-pushed
the
diconnect-check-by-all-part
branch
from
1498d48
to
c1a3185
Compare
driftluo
force-pushed
the
diconnect-check-by-all-part
branch
from
c1a3185
to
1e6edaf
Compare
driftluo
changed the title
|
There is a neglected problem here, causing random errors in the test. Whitelist will auto connect by network, if miss this information in the test, there will be various strange problems. |
u2
approved these changes
Oct 11, 2019
|
bors r=u2,keroro520,quake |
bors bot
added a commit
that referenced
this pull request
Oct 11, 2019
1671: test: generated blocks in the connected state r=u2,keroro520,quake a=driftluo generated blocks in the connected state Co-authored-by: driftluo <[email protected]>
keroro520
suggested changes
Oct 11, 2019
There was a problem hiding this comment.
ckb-failed on spec whitelist_on_session_limit
https://travis-ci.org/keroro520/ckb/jobs/596414021
I guess that the above failure is caused by the same reason as this PR. Please check again.
|
bors r- |
The cause of the problem is not consistent, it is an asynchronous timing problem, I will fix it.... However, due to the automatic connection, this test must be deleted because the object to be tested here cannot be tested. |
…s and auto-connect with whiteli
keroro520
approved these changes
Oct 11, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 11, 2019
1671: test: generated blocks in the connected state r=keroro520 a=driftluo generated blocks in the connected state Co-authored-by: driftluo <[email protected]>
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generated blocks in the connected state