Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow setting the spec file in ckb init. #1682

Merged
merged 1 commit into from
Oct 10, 2019
Merged

feat: Allow setting the spec file in ckb init. #1682

merged 1 commit into from
Oct 10, 2019

Conversation

doitian
Copy link
Member

@doitian doitian commented Oct 4, 2019

Add a new option ckb init --import-spec <file>.

It allows copying the spec file in ckb init from <file>. Specially, when <file> is "-", read the spec file from stdin encoded in base64.

@doitian doitian requested a review from a team October 4, 2019 15:09
@doitian
Copy link
Member Author

doitian commented Oct 10, 2019

bors r=quake,u2

@nervos-bot nervos-bot bot added the s:ready-to-merge Status: Waiting to be merged. label Oct 10, 2019
@u2
Copy link
Contributor

u2 commented Oct 10, 2019

bors r-

conflict

@bors
Copy link
Contributor

bors bot commented Oct 10, 2019

Canceled

Allow copying the spec file in `ckb init` from `<file>`. Specially, when `<file>` is "-", read the spec file from stdin encoded in base64.
@doitian
Copy link
Member Author

doitian commented Oct 10, 2019

bors r=quake,u2

bors bot added a commit that referenced this pull request Oct 10, 2019
1682: feat: Allow setting the spec file in ckb init. r=quake,u2 a=doitian

Add a new option `ckb init --import-spec <file>`.

It allows copying the spec file in `ckb init` from `<file>`. Specially, when `<file>` is "-", read the spec file from stdin encoded in base64.

1700: fix: fix panic when submit tx with low fee rate r=xxuejie,u2,doitian a=jjyr



Co-authored-by: ian <[email protected]>
Co-authored-by: jjy <[email protected]>
@bors
Copy link
Contributor

bors bot commented Oct 10, 2019

Build succeeded

  • continuous-integration/travis-ci/push

@bors bors bot merged commit 2477920 into nervosnetwork:develop Oct 10, 2019
@doitian doitian deleted the init-chainspec-overrides-for-develop branch September 11, 2020 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s:ready-to-merge Status: Waiting to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants