Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tx trace api #181

Merged
merged 3 commits into from
Jan 16, 2019
Merged

tx trace api #181

merged 3 commits into from
Jan 16, 2019

Conversation

zhangsoledad
Copy link
Member

No description provided.

@zhangsoledad zhangsoledad changed the title [WIP] tx trace api tx trace api Jan 11, 2019
@doitian
Copy link
Member

doitian commented Jan 12, 2019

bors try

bors bot added a commit that referenced this pull request Jan 12, 2019
@bors
Try #181:
aba6939
@bors
Copy link
Contributor

bors bot commented Jan 12, 2019

try

Build succeeded

  • continuous-integration/travis-ci/push

quake
quake requested changes Jan 14, 2019
View reviewed changes
pool/src/tests/pool.rs Outdated Show resolved Hide resolved
@zhangsoledad zhangsoledad force-pushed the zhangsoledad/trace branch 3 times, most recently from 9c6277e to 2a8a35d Compare January 14, 2019 12:34
@doitian
Copy link
Member

doitian commented Jan 15, 2019

Travis link to the checks seems broken.

https://travis-ci.com/nervosnetwork/ckb/builds/97198673

doitian
doitian requested changes Jan 15, 2019
View reviewed changes
Copy link
Member

@doitian doitian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should update rpc/doc.md to document the new APIs

@doitian doitian assigned zhangsoledad and unassigned quake Jan 15, 2019
doitian
doitian reviewed Jan 15, 2019
View reviewed changes
rpc/doc.md Outdated Show resolved Hide resolved
@zhangsoledad zhangsoledad force-pushed the zhangsoledad/trace branch 2 times, most recently from 3f10ab5 to 9f89dcf Compare January 16, 2019 08:12
@zhangsoledad
Copy link
Member Author

@doitian fixed

@doitian doitian merged commit e759128 into nervosnetwork:develop Jan 16, 2019
@doitian doitian mentioned this pull request Jan 21, 2019
Merged
@doitian doitian mentioned this pull request Jan 30, 2019
Closed
@zhangsoledad zhangsoledad deleted the zhangsoledad/trace branch August 16, 2019 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quake quake quake approved these changes

@doitian doitian doitian approved these changes

@TheWaWaR TheWaWaR Awaiting requested review from TheWaWaR

@kilb kilb Awaiting requested review from kilb

Assignees

@zhangsoledad zhangsoledad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhangsoledad @doitian @quake