Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: save integration test logs in a specified directory #2053

Merged
merged 1 commit into from
May 1, 2020

Conversation

yangby-cryptape
Copy link
Collaborator

Currently, it's too hard to distinguish between integration test logs and other temporary logs, especially when make integration test to be automated.

@yangby-cryptape yangby-cryptape requested review from a team and zhangsoledad April 30, 2020 09:16
@quake
Copy link
Member

quake commented May 1, 2020

bors r=keroro520,doitian

bors bot added a commit that referenced this pull request May 1, 2020
2050: chore: upgrade p2p/tokio r=TheWaWaR,quake a=driftluo

1. Upgrade p2p, use new `BlockingFlag` to optimize performance
2. Upgrade tokio, allow recursive call `block_in_place`

p2p release note:
```
Bug Fix

    Fix session proto open/close by user part(#220)

Features

    Replace unsplit with assignment(#225)
    Upgrade tokio util(#224)
    Avoids unnecessary session id checking(#223)
    Check all underscore(#228)
    Use flag to control how to use block_in_place(#226)
    More test(#227/#220)
```

tokio release note:
```
Fix
    rt: support block_in_place in more contexts
    stream: no panic in merge() and chain() when using size_hint()
    task: include visibility modifier when defining a task-local
    sync: broadcast closing the channel no longer requires capacity 

Added
    rt: runtime::Handle::block_on
```

2053: test: save integration test logs in a specified directory r=keroro520,doitian a=yangby-cryptape

Currently, it's too hard to distinguish between integration test logs and other temporary logs, especially when make integration test to be automated.

Co-authored-by: driftluo <[email protected]>
Co-authored-by: Boyu Yang <[email protected]>
@bors
Copy link
Contributor

bors bot commented May 1, 2020

This PR was included in a batch that timed out, it will be automatically retried

@bors
Copy link
Contributor

bors bot commented May 1, 2020

Build succeeded:

  • continuous-integration/travis-ci/push

@bors bors bot merged commit c158bde into nervosnetwork:develop May 1, 2020
@yangby-cryptape yangby-cryptape deleted the pr/save-it-logs branch July 9, 2020 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants