Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: deny missing docs #2313

Merged
merged 12 commits into from
Oct 30, 2020
Merged

docs: deny missing docs #2313

merged 12 commits into from
Oct 30, 2020

Conversation

doitian
Copy link
Member

@doitian doitian commented Oct 10, 2020 •
edited
Loading

Mark missing docs then finish all the missing docs todos.

Total progress:

  • 2020-10-13: 2 / 2062
  • 2020-10-20: 320 / 2062
  • 2020-10-29: 351 / 2062 (17%)

Documentation Assignments

  • Submit each section as a single commit in this PR branch.
  • Invite a reviewer to review your commits.
  • Once the commit is approved, add a comment "Section xxx has been reviewed by @xxx".
  • If you want to help, contact the section owner and transfer the section ownership.

Since the assignments check list is too long, I have moved them to a gist:

https://gist.github.com/doitian/2c05d66bfb6b23786b6748c00e4e40f6

@doitian (437)
31 / 437 tasks
@keroro520 (187)
0 / 187 tasks
@chuijiaolianying (19)
0 / 19 tasks
@zhangsoledad (426)
0 / 426 tasks
@quake (358)
0 / 358 tasks
@driftluo (317)
0 / 317 tasks
@yangby-cryptape (318)
318 / 318 tasks

@doitian doitian force-pushed the deny-missing-docs branch 4 times, most recently from edb8393 to 7aa7b79 Compare October 13, 2020 03:46
@yangby-cryptape

This comment has been minimized.

Sign in to view
doitian
doitian commented Oct 20, 2020
View reviewed changes
util/types/src/core/advanced_builders.rs Outdated Show resolved Hide resolved
util/types/src/core/advanced_builders.rs Outdated Show resolved Hide resolved
util/types/src/core/reward.rs Outdated Show resolved Hide resolved
@doitian
Copy link
Member Author

doitian commented Oct 20, 2020

Hint, just search TODO(doc): @yourgithubid in the branch.

@doitian doitian force-pushed the deny-missing-docs branch 2 times, most recently from f2fd210 to 6464ead Compare October 28, 2020 08:57
@doitian
Copy link
Member Author

doitian commented Oct 28, 2020 •
edited by yangby-cryptape
Loading

@yangby-cryptape please help to review ckb-resource

6464ead

Reply by @yangby-cryptape at 2020-10-28 23:09:30: DONE!

yangby-cryptape
yangby-cryptape requested changes Oct 28, 2020
View reviewed changes
resource/src/template.rs Outdated Show resolved Hide resolved
@doitian doitian marked this pull request as ready for review October 29, 2020 09:26
@doitian doitian requested a review from a team October 29, 2020 09:26
@doitian doitian requested a review from a team as a code owner October 29, 2020 09:26
@doitian
Copy link
Member Author

doitian commented Oct 29, 2020

This PR is ready for review. The remaining missing docs marked as TODOs will be fixed in future PRs by assignees.

@yangby-cryptape
Copy link
Collaborator

@doitian CI failed!

@doitian doitian merged commit ee0ccec into develop Oct 30, 2020
@bors bors bot deleted the deny-missing-docs branch October 30, 2020 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangby-cryptape yangby-cryptape yangby-cryptape approved these changes

@jjyr jjyr Awaiting requested review from jjyr

@keroro520 keroro520 Awaiting requested review from keroro520

@quake quake Awaiting requested review from quake

@TheWaWaR TheWaWaR Awaiting requested review from TheWaWaR

@xxuejie xxuejie Awaiting requested review from xxuejie

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doitian @yangby-cryptape