-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Upgrade RPC local_node_id to local_node_info #233
Conversation
"result": { | ||
"addresses": [ | ||
{ | ||
"address": "/ip4/0.0.0.0/tcp/12344/p2p/QmWRU2NSro4wKgVbFX6y8SPFkcJ1tE2X5xzk9msMhdRmdS", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can /p2p/xxxx
be omitted here? because it's duplicated with node_id
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After considering, I think we can leave it here because it is easy to copy-paste or parse in script, a typical node may have 2 addresses(local address and public address), it could have more addresses if it has multiple network interfaces, even it has multi public addresses the duplicate p2p phase is not big deal.
7249713
to
5fdf561
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a BREAKING CHANGE:
section in your feat:
commit message to explain the RPC change.
BREAKING CHANGE: RPC local_node_id no longer exists, use new added RPC local_node_info to get node addresses.
5fdf561
to
236bd4a
Compare
local_node_id
tolocal_node_info