Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade yamux #3208

Merged
merged 1 commit into from
Dec 1, 2021
Merged

chore: upgrade yamux #3208

merged 1 commit into from
Dec 1, 2021

Conversation

driftluo
Copy link
Collaborator

What problem does this PR solve?

In the default configuration, it has no effect, but we can enable the adjustment of window size after hardfork

## yamux 0.3.1-0.3.3 secio 0.5.1

yamux 0.3.2: edition 2018 
yamux 0.3.3 and 0.3.1: edition 2021

### Bug Fix

- Fix yamux window update(#340)

Check List

Tests

  • Unit test
  • Integration test

Release note

None: Exclude this PR from the release note.

@driftluo driftluo requested a review from a team as a code owner November 30, 2021 07:46
@driftluo driftluo added the s:waiting-on-reviewers Status: Waiting for Review label Nov 30, 2021
@driftluo
Copy link
Collaborator Author

driftluo commented Dec 1, 2021

bors r=doitian,TheWaWaR

@driftluo driftluo removed the s:waiting-on-reviewers Status: Waiting for Review label Dec 1, 2021
@bors
Copy link
Contributor

bors bot commented Dec 1, 2021

Build succeeded:

@bors bors bot merged commit 31af347 into nervosnetwork:develop Dec 1, 2021
@driftluo driftluo deleted the upgrade-yamux branch December 1, 2021 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doitian doitian doitian approved these changes

@TheWaWaR TheWaWaR TheWaWaR approved these changes

@keroro520 keroro520 Awaiting requested review from keroro520 keroro520 is a code owner automatically assigned from nervosnetwork/ckb-dev

@BourneNeo BourneNeo Awaiting requested review from BourneNeo BourneNeo is a code owner automatically assigned from nervosnetwork/ckb-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@driftluo @doitian @TheWaWaR