Refactor peer store #349

jjyr · 2019-03-21T07:02:28Z

change modules layout.
remove unnecessary code.
enable file storage mode.

TheWaWaR · 2019-03-22T02:46:58Z

@jjyr
PeerStore API changed, but service/discovery_service.rs not changed.
Do not understand why CI passed.

jjyr · 2019-03-22T02:50:05Z

bors try

bors · 2019-03-22T03:24:55Z

try

Build failed

continuous-integration/travis-ci/push

TheWaWaR · 2019-03-22T04:55:43Z

@jjyr
You can run make ci in your machine, then push.

TheWaWaR · 2019-03-22T07:09:44Z

bors r+

bors · 2019-03-22T07:09:46Z

👎 Rejected by too few approved reviews

TheWaWaR · 2019-03-22T07:10:17Z

bors r+

349: Refactor peer store r=TheWaWaR a=jjyr 1. change modules layout. 2. remove unnecessary code. 3. enable file storage mode. Co-authored-by: jjy <[email protected]>

TheWaWaR · 2019-03-22T07:12:44Z

bors r-

bors · 2019-03-22T07:12:45Z

Canceled

jjyr · 2019-03-22T07:20:55Z

bors r+

349: Refactor peer store r=jjyr a=jjyr 1. change modules layout. 2. remove unnecessary code. 3. enable file storage mode. Co-authored-by: jjy <[email protected]>

bors · 2019-03-22T08:39:45Z

Timed out

jjyr · 2019-03-22T08:42:06Z

bors r+

349: Refactor peer store r=jjyr a=jjyr 1. change modules layout. 2. remove unnecessary code. 3. enable file storage mode. Co-authored-by: jjy <[email protected]>

bors · 2019-03-22T09:29:11Z

Build failed

continuous-integration/travis-ci/push

jjyr · 2019-03-22T09:37:41Z

bors r-
bors r+

349: Refactor peer store r=jjyr a=jjyr 1. change modules layout. 2. remove unnecessary code. 3. enable file storage mode. Co-authored-by: jjy <[email protected]>

bors · 2019-03-22T10:24:40Z

Build succeeded

continuous-integration/travis-ci/push

1793: chore(deps): bump num_cpus from 1.10.1 to 1.11.0 r=doitian a=dependabot-preview[bot] Bumps [num_cpus](https://github.com/seanmonstar/num_cpus) from 1.10.1 to 1.11.0. <details> <summary>Changelog</summary> *Sourced from [num_cpus's changelog](https://github.com/seanmonstar/num_cpus/blob/master/CHANGELOG.md).* > ## v1.11.0 > > #### Features > > - add `hermit` target OS support > - removes `bitrig` support > > #### Fixes > > - fix `get_physical` count with AMD hyperthreading. </details> <details> <summary>Commits</summary> - [`1904840`](seanmonstar/num_cpus@1904840) v1.11.0 - [`a8973cb`](seanmonstar/num_cpus@a8973cb) add support of the unikernel RustyHermit ([#88](https://github-redirect.dependabot.com/seanmonstar/num_cpus/issues/88)) - [`c3d2021`](seanmonstar/num_cpus@c3d2021) Refactor get_physical to sum 'cpu cores' per 'physical id' ([#86](https://github-redirect.dependabot.com/seanmonstar/num_cpus/issues/86)) - [`85d20df`](seanmonstar/num_cpus@85d20df) Avoid allocating a vector and double trimming in get_num_physical_cpus ([#87](https://github-redirect.dependabot.com/seanmonstar/num_cpus/issues/87)) - [`434d29c`](seanmonstar/num_cpus@434d29c) Use ptr::null_mut instead of 0 as *mut ([#84](https://github-redirect.dependabot.com/seanmonstar/num_cpus/issues/84)) - [`3a8994b`](seanmonstar/num_cpus@3a8994b) Remove bitrig support ([#78](https://github-redirect.dependabot.com/seanmonstar/num_cpus/issues/78)) - See full diff in [compare view](seanmonstar/num_cpus@v1.10.1...v1.11.0) </details> <br /> [![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=num_cpus&package-manager=cargo&previous-version=1.10.1&new-version=1.11.0)](https://dependabot.com/compatibility-score.html?dependency-name=num_cpus&package-manager=cargo&previous-version=1.10.1&new-version=1.11.0) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) </details> 1794: chore(deps): bump toml from 0.5.2 to 0.5.5 r=doitian a=dependabot-preview[bot] Bumps [toml](https://github.com/alexcrichton/toml-rs) from 0.5.2 to 0.5.5. <details> <summary>Commits</summary> - [`7512904`](toml-rs/toml-rs@7512904) Bump to 0.5.5 - [`1e6bfbc`](toml-rs/toml-rs@1e6bfbc) replace copied wit filter_map for rustc 1.35 compatibility ([#354](https://github-redirect.dependabot.com/alexcrichton/toml-rs/issues/354)) - [`4673cfd`](toml-rs/toml-rs@4673cfd) Replace the test added by [#349](https://github-redirect.dependabot.com/alexcrichton/toml-rs/issues/349) with a bench ([#351](https://github-redirect.dependabot.com/alexcrichton/toml-rs/issues/351)) - [`4b05a9d`](toml-rs/toml-rs@4b05a9d) update ([#352](https://github-redirect.dependabot.com/alexcrichton/toml-rs/issues/352)) - [`189d2b9`](toml-rs/toml-rs@189d2b9) Bump to 0.5.4 - [`c049b7a`](toml-rs/toml-rs@c049b7a) Decrease deserialization complexity from quadratic to linear ([#349](https://github-redirect.dependabot.com/alexcrichton/toml-rs/issues/349)) - [`ec21d60`](toml-rs/toml-rs@ec21d60) Support for dotted table spans ([#340](https://github-redirect.dependabot.com/alexcrichton/toml-rs/issues/340)) - [`e9f5290`](toml-rs/toml-rs@e9f5290) Switch from linked-hash-map to indexmap - [`8995cef`](toml-rs/toml-rs@8995cef) Spanned: impl PartialEq, Eq, Hash, PartialOrd, Ord in terms of the value ([#344](https://github-redirect.dependabot.com/alexcrichton/toml-rs/issues/344)) - [`9ed2903`](toml-rs/toml-rs@9ed2903) Remove outdated Travis CI badge ([#346](https://github-redirect.dependabot.com/alexcrichton/toml-rs/issues/346)) - Additional commits viewable in [compare view](toml-rs/toml-rs@0.5.2...0.5.5) </details> <br /> [![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=toml&package-manager=cargo&previous-version=0.5.2&new-version=0.5.5)](https://dependabot.com/compatibility-score.html?dependency-name=toml&package-manager=cargo&previous-version=0.5.2&new-version=0.5.5) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) </details> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

jjyr requested review from quake, TheWaWaR and a team March 21, 2019 07:02

bors bot added a commit that referenced this pull request Mar 22, 2019

Try #349:

5f7cbe4

jjyr added 6 commits March 22, 2019 11:29

refactor: rename connected_time to last_connected_at

6ccbf0a

refactor: Remove unnecessary interface from PeerStore

5a78629

refactor: move SqlitePeerStore to correct modules

cf2873f

feat: enable SqlitePeerStore file mode

b6a6cc8

refactor: use vector to dynamic allocation

4224951

fix: rebase

5f7505a

jjyr force-pushed the refactor-peer-store branch from 7e49837 to 5f7505a Compare March 22, 2019 03:44

refactor: use memory mode to run SqlitePeerStore tests

4ea613b

jjyr added 2 commits March 22, 2019 13:16

fix: sqlite peer store benchmark

2ef7fe1

refactor: speed up sqlite peer store tests

f69bde8

nervos-bot bot added the s:waiting-for-bors label Mar 22, 2019

TheWaWaR approved these changes Mar 22, 2019

View reviewed changes

bors bot added a commit that referenced this pull request Mar 22, 2019

Merge #349

8f1199b

349: Refactor peer store r=TheWaWaR a=jjyr 1. change modules layout. 2. remove unnecessary code. 3. enable file storage mode. Co-authored-by: jjy <[email protected]>

chore: update tentacle

017d674

bors bot added a commit that referenced this pull request Mar 22, 2019

Merge #349

21e76e0

349: Refactor peer store r=jjyr a=jjyr 1. change modules layout. 2. remove unnecessary code. 3. enable file storage mode. Co-authored-by: jjy <[email protected]>

bors bot added a commit that referenced this pull request Mar 22, 2019

Merge #349

ca90e69

349: Refactor peer store r=jjyr a=jjyr 1. change modules layout. 2. remove unnecessary code. 3. enable file storage mode. Co-authored-by: jjy <[email protected]>

fix: integration tests config file

d4b7a22

bors bot added a commit that referenced this pull request Mar 22, 2019

Merge #349

567e6d7

349: Refactor peer store r=jjyr a=jjyr 1. change modules layout. 2. remove unnecessary code. 3. enable file storage mode. Co-authored-by: jjy <[email protected]>

bors bot merged commit d4b7a22 into nervosnetwork:develop Mar 22, 2019

jjyr deleted the refactor-peer-store branch March 22, 2019 10:29

doitian mentioned this pull request Mar 27, 2019

Rc/v0.8.0 #358

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor peer store #349

Refactor peer store #349

jjyr commented Mar 21, 2019

TheWaWaR commented Mar 22, 2019 •

edited

Loading

jjyr commented Mar 22, 2019

bors bot commented Mar 22, 2019

TheWaWaR commented Mar 22, 2019

TheWaWaR commented Mar 22, 2019

bors bot commented Mar 22, 2019

TheWaWaR commented Mar 22, 2019

TheWaWaR commented Mar 22, 2019

bors bot commented Mar 22, 2019

jjyr commented Mar 22, 2019

bors bot commented Mar 22, 2019

jjyr commented Mar 22, 2019

bors bot commented Mar 22, 2019

jjyr commented Mar 22, 2019

bors bot commented Mar 22, 2019

Refactor peer store #349

Refactor peer store #349

Conversation

jjyr commented Mar 21, 2019

TheWaWaR commented Mar 22, 2019 • edited Loading

jjyr commented Mar 22, 2019

bors bot commented Mar 22, 2019

try

Build failed

TheWaWaR commented Mar 22, 2019

TheWaWaR commented Mar 22, 2019

bors bot commented Mar 22, 2019

TheWaWaR commented Mar 22, 2019

TheWaWaR commented Mar 22, 2019

bors bot commented Mar 22, 2019

Canceled

jjyr commented Mar 22, 2019

bors bot commented Mar 22, 2019

Timed out

jjyr commented Mar 22, 2019

bors bot commented Mar 22, 2019

Build failed

jjyr commented Mar 22, 2019

bors bot commented Mar 22, 2019

Build succeeded

TheWaWaR commented Mar 22, 2019 •

edited

Loading