Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: verify worker exit when signal_exit is_cancelled #4612

Merged

Conversation

chenyukang
Copy link
Collaborator

@chenyukang chenyukang commented Aug 25, 2024

What problem does this PR solve?

When there are a lot of transaction pending in verify queue, ctrl-c may need to wait worker finishing all of them, because of this loop in verify worker, there is no chance to update self.status since worker is executing process_inner.

What is changed and how it works?

Worker should return from iteration when exit signal is sent.

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Release note

Title Only: Include only the PR title in the release note.

@chenyukang chenyukang requested a review from a team as a code owner August 25, 2024 03:59
@chenyukang chenyukang requested review from quake and removed request for a team August 25, 2024 03:59
@chenyukang chenyukang added this pull request to the merge queue Aug 25, 2024
Merged via the queue into nervosnetwork:develop with commit 8744829 Aug 25, 2024
32 checks passed
@doitian doitian mentioned this pull request Aug 28, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants