Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove empty entry for OrphanPool #4676

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Remove empty entry for OrphanPool #4676

merged 1 commit into from
Oct 16, 2024

Conversation

eval-exec
Copy link
Collaborator

@eval-exec eval-exec commented Oct 14, 2024 •
edited
Loading

What problem does this PR solve?

When an entry in OrphanPool is empty, it should be removed.

What is changed and how it works?

What's Changed:

Related changes

  • Remove empty entry in OrphanPool

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note 

Title Only: Include only the PR title in the release note.

doitian
doitian reviewed Oct 14, 2024
View reviewed changes
tx-pool/src/process.rs Outdated Show resolved Hide resolved
@eval-exec eval-exec force-pushed the exec/destruct-tx-to-get-wtx_hash branch from 7864bcd to 3983816 Compare October 15, 2024 02:29
@eval-exec eval-exec force-pushed the exec/destruct-tx-to-get-wtx_hash branch 4 times, most recently from f2014f1 to 8cd62ce Compare October 15, 2024 03:35
@eval-exec eval-exec requested a review from quake October 15, 2024 03:36
@eval-exec eval-exec marked this pull request as ready for review October 15, 2024 03:36
@eval-exec eval-exec requested a review from a team as a code owner October 15, 2024 03:36
chenyukang
chenyukang previously approved these changes Oct 15, 2024
View reviewed changes
@eval-exec eval-exec changed the title Destruct TransactionView to get wtx_hash Destruct TransactionView to get wtx_hash, remove empty entry for OrphanPool Oct 15, 2024
@eval-exec eval-exec force-pushed the exec/destruct-tx-to-get-wtx_hash branch from 8cd62ce to bb9fa5c Compare October 16, 2024 01:39
@eval-exec eval-exec changed the title Destruct TransactionView to get wtx_hash, remove empty entry for OrphanPool Remove empty entry for OrphanPool Oct 16, 2024
@eval-exec eval-exec mentioned this pull request Oct 16, 2024
Merged
@zhangsoledad zhangsoledad added this pull request to the merge queue Oct 16, 2024
zhangsoledad added a commit that referenced this pull request Oct 16, 2024
@zhangsoledad
Merge pull request #4677 from eval-exec/exec/0.119.x-fix-high-memory-…
c4dd450 
…backport-4676

Backport #4676, Remove empty entry for `OrphanPool`
Merged via the queue into nervosnetwork:develop with commit 248cfa8 Oct 16, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doitian doitian doitian left review comments

@zhangsoledad zhangsoledad zhangsoledad approved these changes

@chenyukang chenyukang chenyukang left review comments

@quake quake Awaiting requested review from quake

@driftluo driftluo Awaiting requested review from driftluo

@yangby-cryptape yangby-cryptape Awaiting requested review from yangby-cryptape

Assignees
No one assigned
Labels
m:tx-pool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eval-exec @doitian @chenyukang @zhangsoledad