fix: calculate the current median time from tip #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![nervos-bot[bot]](https://avatars.githubusercontent.com/in/22976?s=60&v=4){kind=small}
|
@TheWaWaR is assigned as the leading reviewer |
|
Block by #854 |
|
@nervos-bot-user ci status e3e203a Sync status |
|
@nervos-bot-user ci status e3e203a Sync status, again. |
quake
requested changes
May 23, 2019
quake
approved these changes
May 23, 2019
keroro520
force-pushed
the
fix-current-median-time
branch
2 times, most recently
from
545dcd0
to
2884673
Compare
keroro520
force-pushed
the
fix-current-median-time
branch
from
2884673
to
91b3949
Compare
quake
approved these changes
May 24, 2019
keroro520
changed the title
keroro520
added
the
breaking change
Original implementation use [Tip-BlockMedianCount .. Tip-1] to calculate the current block median time. According to the notion of BlockMedianTime in https://github.com/bitcoin/bips/blob/master/bip-0113.mediawiki#specification , here change to use [Tip-BlockMedianCount+1 .. Tip] instead.
keroro520
force-pushed
the
fix-current-median-time
branch
from
91b3949
to
1977439
Compare
TheWaWaR
reviewed
May 28, 2019
|
|
||
| pub fn since_from_absolute_block_number(block_number: BlockNumber) -> u64 { | ||
| FLAG_SINCE_BLOCK_NUMBER | block_number | ||
| } |
There was a problem hiding this comment.
I think those functions should add to enum SinceMetric and should use in send_transaction RPC in the future.
TheWaWaR
approved these changes
May 28, 2019
This was referenced Jun 3, 2019
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Original implementation use
[Tip-BlockMedianCount .. Tip-1]to calculate the current block median time. According to the notion of BlockMedianTime in bip-0113 , here change to use[Tip-BlockMedianCount+1 .. Tip]instead.