feat: Alert system #887
Closed
feat: Alert system #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@quake is assigned as the chief reviewer |
|
CI status of the fork branch is |
janx
reviewed
May 23, 2019
| @@ -0,0 +1,26 @@ | |||
| [package] | |||
| name = "ckb-alert-system" | |||
There was a problem hiding this comment.
ckb-network-alert is more appropriate.
https://github.com/nervosnetwork/ckb/pull/887/files#diff-f9056d164d152ac4dad0a349994e8c30R138 All alert messages need to be verified with signatures before the relay. |
|
I decide split multisig to another PR. |
This was referenced Jun 3, 2019
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce:
https://en.bitcoin.it/wiki/Alert_system
Purpose:
Implement the alert system in CKB for urgent situation,
In CKB early stage we may meet the same crisis bugs that Bitcoin meet,
in urgent case, CKB core team can send an alert message across CKB P2P network,
the client will show the alert message, the other behaviors of CKB node will not change.
The Alert System will be removed soon once the CKB network is considered mature.
Implement:
alt.send_alert.