-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: wrap the log macros to fix ill formed macros #897
Merged
quake
merged 9 commits into
nervosnetwork:develop
from
yangby-cryptape:fix-ill-formed-macros
Jun 1, 2019
Merged
feat: wrap the log macros to fix ill formed macros #897
quake
merged 9 commits into
nervosnetwork:develop
from
yangby-cryptape:fix-ill-formed-macros
Jun 1, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@quake is assigned as the chief reviewer |
Any plan to undraft? The team, @nervosnetwork/ckb-dev, Any option? |
Prefer to use |
Reply @keroro520:
|
Soga. Thanks for your reply. |
yangby-cryptape
force-pushed
the
fix-ill-formed-macros
branch
3 times, most recently
from
May 31, 2019 10:12
62f847f
to
a38a22b
Compare
TheWaWaR
approved these changes
May 31, 2019
yangby-cryptape
force-pushed
the
fix-ill-formed-macros
branch
from
May 31, 2019 10:15
a38a22b
to
dfc944a
Compare
quake
approved these changes
Jun 1, 2019
This was referenced Jun 3, 2019
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits:
And, we have to update the log filters, add prefix
ckb-
for all our crates, since I usetarget: env!("CARGO_PKG_NAME")
.