-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update devchain.md #202
Update devchain.md #202
Conversation
update account generation info and improve language
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lgtm |
@@ -71,7 +71,7 @@ ckb-cli account new | |||
<summary>(click here to view result)</summary> | |||
|
|||
```bash | |||
Your new account is locked with a password. Please give a password. Do not forget this password. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This text should not change because it matches the output from ckb-cli.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous output is the old output, and the content needs to be updated to match the new output to facilitate user understanding. The relevant ckb-cli version is
ckb-cli --version
ckb-cli 1.5.0 (f043bf1 2023-09-14)
ckb-cli account new
Your new account is locked with a password. Please give a password. Do not forget this password.
Password:
Repeat password:
address:
mainnet: ckb1qzda0cr08m85hc8jlnfp3zer7xulejywt49kt2rr0vthywaa50xwsqghklqs0vttylku4pjxhr8hxsaratn8muc28r7vu
testnet: ckt1qzda0cr08m85hc8jlnfp3zer7xulejywt49kt2rr0vthywaa50xwsqghklqs0vttylku4pjxhr8hxsaratn8mucy4g3xy
address(deprecated):
mainnet: ckb1qyqp0d7pq7ckkflde2rydwx0wdp686hx0hesvfqn3l
testnet: ckt1qyqp0d7pq7ckkflde2rydwx0wdp686hx0hes3v7var
lock_arg: 0x17b7c107b16b27edca8646b8cf7343a3eae67df3
lock_hash: 0x9fecea1600fecfac989b2d15dc227b885afe68f5b652a1a159b59cb69e83ddae
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are in agreement. The text in the guide needs to match the output of ckb-cli
. The correct text is:
Your new account is locked with a password. Please give a password. Do not forget this password.
@@ -221,14 +221,18 @@ ckb-cli account new | |||
<summary>(click here to view result)</summary> | |||
|
|||
```bash | |||
Your new account is locked with a password. Please give a password. Do not forget this password. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as before. Do not change because this should match the ckb-cli output.
@@ -221,14 +221,18 @@ ckb-cli account new | |||
<summary>(click here to view result)</summary> | |||
|
|||
```bash | |||
Your new account is locked with a password. Please give a password. Do not forget this password. | |||
gitpod /workspace/forcerelay_deployment_playground (main) $ ckb-cli account new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Start the line with "$". Remove anything specific to your local environment.
@@ -349,19 +353,23 @@ account new | |||
<summary>(click here to view result)</summary> | |||
|
|||
```bash | |||
Your new account is locked with a password. Please give a password. Do not forget this password. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as the others. Do not change the output.
* updated info&text regarding `ckb-cli account new`, `ckb --version`, `ckb-cli --version`, `ckb init --chain dev` * reverted the output text * removed local environment info
update account generation info and improve language