feat: add payment hash type #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doitian
added a commit
to doitian/fiber
that referenced
this pull request
Jun 27, 2024
Allow choosing the hash algorithm when adding the HTLC output. Related PR: nervosnetwork/fiber-scripts#6
doitian
added a commit
to doitian/fiber
that referenced
this pull request
Jun 27, 2024
Allow choosing the hash algorithm when adding the HTLC output. Related PR: nervosnetwork/fiber-scripts#6
doitian
added a commit
to doitian/fiber
that referenced
this pull request
Jun 27, 2024
Allow choosing the hash algorithm when adding the HTLC output. Related PR: nervosnetwork/fiber-scripts#6
doitian
added a commit
to doitian/fiber
that referenced
this pull request
Jun 27, 2024
Allow choosing the hash algorithm when adding the HTLC output. Related PR: nervosnetwork/fiber-scripts#6
doitian
added a commit
to doitian/fiber
that referenced
this pull request
Jun 27, 2024
Allow choosing the hash algorithm when adding the HTLC output. Related PR: nervosnetwork/fiber-scripts#6 - Added a field `hash_algorithm` when adding TLC - Save the `hash_algorithm` in the internal TLC struct - Check hash against preimage using the saved `hash_algorithm` - Added `hash_algorithm` in the invoice as a new attribute
doitian
added a commit
to doitian/fiber
that referenced
this pull request
Jun 28, 2024
Allow choosing the hash algorithm when adding the HTLC output. Related PR: nervosnetwork/fiber-scripts#6 - Added a field `hash_algorithm` when adding TLC - Save the `hash_algorithm` in the internal TLC struct - Check hash against preimage using the saved `hash_algorithm` - Added `hash_algorithm` in the invoice as a new attribute
doitian
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR added payment hash type for sha256 by using the high 7 bits of
htlc_typefield in witness.