Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): add tests for invoice check signature #225

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

chenyukang
Copy link
Collaborator

we have build_with_sign support for signature to make sure invoice is not modified after generated.

maybe we need to use it for PRC:

match invoice_builder.build() {

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.00%. Comparing base (01c7024) to head (627f86c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #225   +/-   ##
=======================================
  Coverage   40.99%   41.00%           
=======================================
  Files          51       51           
  Lines       36761    36761           
=======================================
+ Hits        15072    15073    +1     
+ Misses      21689    21688    -1     
Flag Coverage Δ
unittests 41.00% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@quake quake merged commit e9e535a into nervosnetwork:main Oct 14, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants