Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove address and script convertion from ckb-sdk-js #2801

Merged

Conversation

zhangyouxin
Copy link
Contributor

Description

remove scriptToAddress and addressToScript usage of ckb-sdk-js

Resolve part of: Magickbase/neuron-public-issues#201

packages/neuron-wallet/src/services/cells.ts Outdated Show resolved Hide resolved
packages/neuron-wallet/src/services/transaction-sender.ts Outdated Show resolved Hide resolved
@zhangyouxin
Copy link
Contributor Author

zhangyouxin commented Aug 16, 2023

/package
Packaging for test is done in 5874231165. @zhangyouxin

@Keith-CY Keith-CY added this pull request to the merge queue Aug 24, 2023
Merged via the queue into nervosnetwork:develop with commit 9d585fe Aug 24, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants