Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove usage of serialization methods from ckb-sdk-js #2803

Merged
merged 3 commits into from
Aug 25, 2023
Merged

refactor: remove usage of serialization methods from ckb-sdk-js #2803

merged 3 commits into from
Aug 25, 2023

Conversation

zhangyouxin
Copy link
Contributor

Description

remove serializeXXX usage of ckb-sdk-js

Resolve part of: Magickbase/neuron-public-issues#201

@zhangyouxin zhangyouxin mentioned this pull request Aug 10, 2023
Closed
@zhangyouxin
Copy link
Contributor Author

zhangyouxin commented Aug 16, 2023 •
edited by github-actions bot
Loading

/package
Packaging for test is done in 5873594331. @zhangyouxin

@zhangyouxin zhangyouxin mentioned this pull request Aug 25, 2023
Closed
35 tasks
@Keith-CY Keith-CY added this pull request to the merge queue Aug 25, 2023
Merged via the queue into nervosnetwork:develop with commit 5de2a01 Aug 25, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keith-CY Keith-CY Keith-CY approved these changes

@homura homura homura approved these changes

@WhiteMinds WhiteMinds WhiteMinds approved these changes

@yanguoyu yanguoyu yanguoyu approved these changes

@silySuper silySuper silySuper approved these changes

@devchenyan devchenyan Awaiting requested review from devchenyan

@FrederLu FrederLu Awaiting requested review from FrederLu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zhangyouxin @Keith-CY @homura @WhiteMinds @yanguoyu @silySuper