Modify 0x01 short format to fit multisig lock standard. #141
Conversation
|
LGTM |
| S | R | M | N | Pubkey1 | Pubkey2 | ... | ||
| ``` | ||
|
|
||
| Where S/R/M/N are four single byte unsigned integers, ranging from 0 to 255, and Pubkeys are SECP256K1 public keys. S is format version, currently fixed to 0. M/N means the user must provide M of N signatures to unlock the cell. And R means the provided signatures at least match the first R items of the Pubkey list. |
There was a problem hiding this comment.
In the original design S is a reserved field for future use, occupied 1 byte.
There was a problem hiding this comment.
For what kind of use? If there's no explicit use I prefer to remove it. We can use a new code_hash_index if we want to add a new multisig format in the future.
There was a problem hiding this comment.
Not sure yet, it brings some extensibility,
we may use it to store flags to enable the new features. Or use it as a version to allow compatible changes in the future.
Of cause, use code_hash_index can also achieve the above. what do you think? @CipherWang
There was a problem hiding this comment.
The code nervosnetwork/ckb-system-scripts#60 is supposed to be freeze, we decide to do not touch the current code, we still keep the S.
No description provided.