Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zlib compression does not seem to work in 0.80+ versions of TIC-80 #1268

Closed
KatPurpy opened this issue Dec 10, 2020 · 9 comments
Closed

Zlib compression does not seem to work in 0.80+ versions of TIC-80 #1268

KatPurpy opened this issue Dec 10, 2020 · 9 comments
Assignees

Comments

@KatPurpy
Copy link

KatPurpy commented Dec 10, 2020

If I make possibly more than 64k of JavaScript then loading such cartridge will result in TIC-80 totally ignoring code and saying "the code is empty!"
изображение

What is more weird that CART2PRJ utility will also ignore code resulting in project cart's code part being empty but PRJ2CART will embed code into the cartridge

What is even more weird that loading project directly (for example by dragging project file on TIC-80 icon) makes the game load just fine

Here are the test carts I used to check if the bug wasn't game specific, they contain a lot of pain: tic80_compression_issue.zip

@nesbox
Copy link
Owner

nesbox commented Dec 10, 2020

Reproduced, it's weird.
Thanks.

@nesbox nesbox self-assigned this Dec 10, 2020
@KatPurpy
Copy link
Author

Also I would like to note that exporting on TIC-80 (latest commit) that was fed big project file will result in native TIC-80 with the default hello world cartridge

@nesbox
Copy link
Owner

nesbox commented Dec 10, 2020

Ahh, all is ok, you have to use prj2cart instead cart2prj.
You load .js as .tic file and convert it to .tic file and got cart with garbage :)

@nesbox
Copy link
Owner

nesbox commented Dec 10, 2020

Also I would like to note that exporting on TIC-80 (latest commit) that was fed big project file will result in native TIC-80 with the default hello world cartridge

What OS are you exporting? just tested export win game.exe and all is ok.

@KatPurpy
Copy link
Author

KatPurpy commented Dec 10, 2020

Ahh, all is ok, you have to use prj2cart instead cart2prj.
You load .js as .tic file and convert it to .tic file and got cart with garbage :)

I had typoed util names

@KatPurpy
Copy link
Author

What OS are you exporting? just tested export win game.exe and all is ok.

Windows 64 bit, TIC-80 compiled with MinGW

@KatPurpy
Copy link
Author

It seems to be the main problem was that I mixed up previous version utils with current TIC-80...

But now i am having other problem. Latest TIC-80 exports hello world if it was started using project file. The version I was using did not have such bug (0.90.1400)

@nesbox
Copy link
Owner

nesbox commented Dec 10, 2020

The problem was with non-ASCII chars in the path, I fixed it here a42e9f3.
Please, try to export win game.exe now.
Thanks.

@nesbox nesbox closed this as completed Dec 10, 2020
@KatPurpy
Copy link
Author

The bug seems to be gone. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants