Fix segmentation fault caused by findMatchedDelim unsafe NULL pointer #1094
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
built on current master.
In the code editor, trying to highlight a matching delimiter in the following code will cause segmentation fault.
func())))))
findMatchedDelim may return NULL, which should instantaneously break out of the loop and avoid dereferencing a NULL pointer when checking for the loop condition.
Also, the
current
pointer should probably be bound by TIC_CODE_SIZE (it currently isn't and looks like it can go outside of the code memory segment).