(chore) move moonscript into separate C file #1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would this be good? If so I can do the same with Fennell... |
joshgoebel
changed the title
nesbox
requested changes
Nov 5, 2021
src/api/squirrel.c
Outdated
| @@ -1447,7 +1447,7 @@ static void squirrel_open_builtins(HSQUIRRELVM vm) | |||
| sq_poptop(vm); | |||
| } | |||
|
|
|||
| static void initAPI(tic_core* core) | |||
| static void initLuaAPI(tic_core* core) | |||
There was a problem hiding this comment.
It looks like the function was accidentally renamed here, there should be no mention of Lua in the Squirrel module.
src/api/wren.c
Outdated
| @@ -1395,7 +1395,7 @@ static WrenForeignMethodFn bindForeignMethod( | |||
| return foreignTicMethods(fullName); | |||
| } | |||
|
|
|||
| static void initAPI(tic_core* core) | |||
| static void initLuaAPI(tic_core* core) | |||
There was a problem hiding this comment.
Same here, please fix if not difficult.
Thank you.
|
Yeah, no problem. I'll fix this up and make sure the tests are green. Just didn't want to throw more work at this if you aren't ok with the change in general. |
|
Yeah, not sure this was 100% ready yet. :) You got to it too fast. |
|
ok, waiting... :) |
|
But you already merged it... did you get it working or should I just open a new PR? :-) |
|
Honestly, I don't know what to do in this case :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feels like every language should have their own C file in
api... so I wonder if this should be broken out?