Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small changes to the Ruby bindings #1733

Merged
merged 67 commits into from
Dec 11, 2021
Merged

Conversation

remi6397
Copy link
Contributor

As suggested in #1726.

Jeremiasz Nelz added 30 commits December 4, 2021 11:05
* Mention Ruby in features
* Attribution
Current behavior assumes that comments comprise
exactly two characters, such as "--" or "//".

Many languages, such as Ruby and Python, use
a single character, such as the pound sign
or the ASCII quotation mark to signal
a single-line comment.
Github Actions seems to also prefer the UNIX-native
prefix on Windows CMake
Created a gembox containing only
useful gems
This reverts commit 1a8bf83.

It turns out that wrapping CMake's poor cross build support
was not a good idea after all.
CMake's env helper is broken on Windows OS :/
* Genericize cross compilation
* Clean mruby build artifacts with make/ninja clean
Some toolchains seem to work better this way.
@remi6397
Copy link
Contributor Author

Github spewed redundant commits out at me again… 😕

Copy link
Owner

@nesbox nesbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@nesbox nesbox merged commit bdb2ef8 into nesbox:master Dec 11, 2021
nesbox added a commit that referenced this pull request Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants