-
-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small changes to the Ruby bindings #1733
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Mention Ruby in features * Attribution
Current behavior assumes that comments comprise exactly two characters, such as "--" or "//". Many languages, such as Ruby and Python, use a single character, such as the pound sign or the ASCII quotation mark to signal a single-line comment.
Github Actions seems to also prefer the UNIX-native prefix on Windows CMake
Created a gembox containing only useful gems
This reverts commit 1a8bf83. It turns out that wrapping CMake's poor cross build support was not a good idea after all.
CMake's env helper is broken on Windows OS :/
* Genericize cross compilation * Clean mruby build artifacts with make/ninja clean
Some toolchains seem to work better this way.
Github spewed redundant commits out at me again… 😕 |
nesbox
approved these changes
Dec 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
nesbox
added a commit
that referenced
this pull request
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #1726.