faster drawTile, remove repeat clipping checks #1801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`drawTile` appears to be taking clipping into account, yet in setPixel for every single pixel we check the clipping individually... it seems this is not necessary. This adds a new `setPixelFast` that avoids the repeat checks. I see about a 4-5% increase in benchmarks for just sprite draws.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1796 .
drawTileappears to be taking clipping into account, yet insetPixel for every single pixel we check the clipping
individually... it seems this is not necessary.
This adds a new
setPixelFastthat avoids the repeat checks.I see about a 4-5% increase in benchmarks for just sprite draws.