Add C template #1981
Add C template #1981
Conversation
Implements a C WASM template and build system.
templates/c/src/tic80.h
Outdated
| void map(int32_t x, int32_t y, int32_t w, int32_t h, int32_t sx, int32_t sy, uint32_t* transcolors, int32_t colorcount, int32_t scale, int32_t remap); | ||
|
|
||
| WASM_IMPORT("memcpy") | ||
| void memcpy_tic(uint32_t copyto, uint32_t copyfrom, uint32_t length); |
There was a problem hiding this comment.
Would tic_memcpy make more sense? I'm not sure, but this is one of the few pieces that caught my eye. I assume this is because of the C built-in memcpy function?
There was a problem hiding this comment.
Yep, it is due to conflicts with the C standard library. While tic_memcpy, would be the more normal way to say the function name, in practice when you want to use memcpy you would probably just start typing it without realizing tic_ should be in front, whereas it being treated as a suffix allows for IntelliSense to catch it.
Having it be a suffix too makes it feel less inconsistent. If two of the function names began with tic_, then it would be strange for not all of them to begin with this prefix.
There was a problem hiding this comment.
You make a good case...
There was a problem hiding this comment.
As pointed out elsewhere C's own native memcpy would likely be sufficient - there isn't supposed to be any magic.... is tapping into that a possibility?
There was a problem hiding this comment.
I didn't know that was allowed for this, I assumed TIC's memcpy and memset were special.
There was a problem hiding this comment.
They shouldn't be. The WASM VM has access to all the RAM - it should be able to move it about at at will . Really the memcpy and memset make a whole lot less sense when you're in C as you have directly access to RAM. Remember most people are using scripting runtime so the only way to get to the devices 96kb of MMIO is via these special functions, where-as in the WASM runtime all the memory is just freely available.
There was a problem hiding this comment.
Unless the API is different though, that's a sticky point... we'd prefer the same TIC API arguments, but if we used native memcpy behind the scenes I think that'd be fine. So is that doable?
There was a problem hiding this comment.
Yes, I have removed these TIC functions and tested the standard memset and it works fine.
There was a problem hiding this comment.
Lets just add a mention to the README that for simplicity and to avoid conflicts one should use the standard C memory functions rather than the TIC api ones...
There was a problem hiding this comment.
I have updated the README. I think the wording is ok, but I'm not sure.
These functions are already part of C.
Gitignore you are killing me.
|
I reworded a bit... you happy with everything else? |
Co-authored-by: Josh Goebel <[email protected]>
I just updated the header with some fixes, I think it's good now. |
templates/c/src/tic80.h
Outdated
| KEY_MINUS, | ||
| KEY_EQUALS, |
|
Lets just fix the indent and I think this is looking great! @Gota7 Thanks for all the assistance! |
Implements a C WASM template and build system.