1.1.3 broke passing Address type objects in from/to/cc/etc... #34
Labels
bug
Something isn't working
Comments
|
Agree. There is no reason to restrict the from and to like that. IMHO, this commit should be undone. |
sdgoij
added a commit
to sdgoij/nestjs-nodemailer
that referenced
this issue
Sep 24, 2019
…Options SendMailOptions extends nodemailer.SendMailOptions (alias of nodemailer.Mail.Options[1]) so it inherits all properties defined there. Addresses issue nest-modules#33 and nest-modules#34 1. https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/nodemailer/lib/mailer/index.d.ts#L96
sdgoij
added a commit
to sdgoij/nestjs-nodemailer
that referenced
this issue
Sep 24, 2019
…Options SendMailOptions extends nodemailer.SendMailOptions (alias of nodemailer.Mail.Options[1]) so it inherits all properties defined there. Addresses issue nest-modules#33 and nest-modules#34 1. https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/nodemailer/lib/mailer/index.d.ts#L96
juandav
added a commit
that referenced
this issue
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This patch release change is actually a bug/breaking change.
Mail.Optionsincludesfrom?: string | Address;,to?: string | Address | Array<string | Address>;, etc... but this change locks the options down so that only strings are accepted.Before this patch release I had code with
from: { name: 'My Site', address: this.confirmEmail },which after upgrading now instead emits a TypeScript error ofType '{ name: string; address: string; }' is not assignable to type 'string'.The text was updated successfully, but these errors were encountered: