Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review parameter names relating to synapse models #250

Closed
heplesser opened this issue Mar 2, 2016 · 2 comments · Fixed by #1282
Closed

Review parameter names relating to synapse models #250

heplesser opened this issue Mar 2, 2016 · 2 comments · Fixed by #1282
Assignees
@hakonsbm
Labels
I: User Interface Users may need to change their code due to changes in function calls S: Normal Handle this with default priority T: Discussion Still searching for the right way to proceed / suggestions welcome ZC: Kernel DO NOT USE THIS LABEL ZP: Pending DO NOT USE THIS LABEL
Milestone
NEST 3.0

Comments

@heplesser
Copy link
Contributor

At present, different parts of NEST use different terms to refer to synapse models:

  • In the syn_spec dictionary passed to Connect, the synapse model is passed as model
  • GetConnections uses synapse_model
  • DataConnect uses synapsemodel according to documentation
  • GetDefaults returns an entry synapsemodel
    We should try to find a way to systematize this. Unfortunately, this may break a lot of existing code.

This is a follow-up to trac.876.
@heplesser heplesser added this to the NEST 3.0 milestone Jun 29, 2017
@heplesser heplesser added ZC: Kernel DO NOT USE THIS LABEL I: User Interface Users may need to change their code due to changes in function calls ZP: Pending DO NOT USE THIS LABEL S: Normal Handle this with default priority T: Discussion Still searching for the right way to proceed / suggestions welcome labels Jun 29, 2017
@terhorstd
Copy link
Contributor

Conclusion from NEST3 VC discussion today: use synapse_model everywhere.

@heplesser heplesser assigned hakonsbm and unassigned suku248 Apr 8, 2019
@hakonsbm
Copy link
Contributor

Fixed with 41c4071 in https://github.com/compneuronmbu/nest-simulator/tree/nest-3

@stinebuu stinebuu mentioned this issue Nov 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hakonsbm hakonsbm

Labels
I: User Interface Users may need to change their code due to changes in function calls S: Normal Handle this with default priority T: Discussion Still searching for the right way to proceed / suggestions welcome ZC: Kernel DO NOT USE THIS LABEL ZP: Pending DO NOT USE THIS LABEL
Projects
None yet
Milestone
NEST 3.0
Development

Successfully merging a pull request may close this issue.

Introducing NEST 3.0! nest/nest-simulator
4 participants
@heplesser @hakonsbm @suku248 @terhorstd