-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing NEST 3.0! #1282
Merged
Introducing NEST 3.0! #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stinebuu
commented
Sep 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have gone through all the changes during the Jülich hackathon. These are the smaller comments we have.
stinebuu
force-pushed
the
nest-3
branch
2 times, most recently
from
October 11, 2019 08:53
a102aa3
to
7d8ef1d
Compare
- Renamed target_positions and sources to be more descriptive. - Using range-based for loop
- CMake will now try to compile with Boost by default. - Added option to try forcing compilation with Boost, even if not found. This is needed when using a compiler wrapper, such as on Piz Daint, where Boost is not found by CMake, but the wrapper makes it available.
Remove handling of external POSIX signals sent to NEST.
Hike minimum required CMake to 3.12 and add support for OpenMP with Apple Clang.
correct colors in NEST 2.X vs. NEST 3.0 conversion reference guide
🍾 🎈 🎉 💃 🕺Many thanks and congratulations to all contributors, reviewers and testers! ❤️ |
terhorstd
added
I: Behavior changes
Introduces changes that produce different results for some users
S: Critical
Needs to be addressed immediately
T: Enhancement
New functionality, model or documentation
labels
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
I: Behavior changes
Introduces changes that produce different results for some users
S: Critical
Needs to be addressed immediately
T: Enhancement
New functionality, model or documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains most of the new features introduced with NEST 3.0. Most noticeably
Work done by @hakonsbm, @jougs, @heplesser and me.
We are currently reviewing and fixing issues, so this is still a little bit in development. Nevertheless, please try it out and review.
Enjoy!
😄
This list of issues is mainly here for closing them automatically once the PR is merged.
From NESTio: fixes #918, fixes #624, and fixes #1215.
From nest-3: fixes #1275, fixes #1090, fixes #1167, fixes #772, fixes #588, fixes #537, fixes #971, fixes #250, fixes #244, fixes #1248, fixes #1360, fixes #193, fixes #192, fixes #741, fixes #1391, fixes #555, fixes #1382, fixes #1326.