Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing NEST 3.0! #1282

Merged
merged 1,873 commits into from
Feb 3, 2020
Merged

Introducing NEST 3.0! #1282

merged 1,873 commits into from
Feb 3, 2020

Conversation

stinebuu
Copy link
Contributor

@stinebuu stinebuu commented Sep 9, 2019

This PR contains most of the new features introduced with NEST 3.0. Most noticeably

  • subnets and SiblingContainters are removed
  • GIDCollection improved
  • Node and Connection parametrization
  • PyNEST topology module integrated into nest
  • New recording back-end

Work done by @hakonsbm, @jougs, @heplesser and me.

We are currently reviewing and fixing issues, so this is still a little bit in development. Nevertheless, please try it out and review.

Enjoy!

😄


This list of issues is mainly here for closing them automatically once the PR is merged.

From NESTio: fixes #918, fixes #624, and fixes #1215.

From nest-3: fixes #1275, fixes #1090, fixes #1167, fixes #772, fixes #588, fixes #537, fixes #971, fixes #250, fixes #244, fixes #1248, fixes #1360, fixes #193, fixes #192, fixes #741, fixes #1391, fixes #555, fixes #1382, fixes #1326.

@stinebuu stinebuu changed the title NEST 3.0! Introducing NEST 3.0! Sep 10, 2019
Copy link
Contributor Author

@stinebuu stinebuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have gone through all the changes during the Jülich hackathon. These are the smaller comments we have.

examples/nest/hpc_benchmark.sli Outdated Show resolved Hide resolved
examples/nest/hpc_benchmark.sli Outdated Show resolved Hide resolved
examples/nest/hpc_benchmark_2_16.sli Outdated Show resolved Hide resolved
examples/nest/music/spike_exporter.sli Outdated Show resolved Hide resolved
extras/userdoc/md/GIDCollections.md Outdated Show resolved Hide resolved
topology/layer_impl.h Outdated Show resolved Hide resolved
topology/topology.h Show resolved Hide resolved
topology/topologymodule.cpp Show resolved Hide resolved
topology/topologymodule.cpp Outdated Show resolved Hide resolved
topology/topologymodule.cpp Outdated Show resolved Hide resolved
hakonsbm and others added 24 commits October 22, 2019 14:38
- Renamed target_positions and sources to be more descriptive.
- Using range-based for loop
- CMake will now try to compile with Boost by default.
- Added option to try forcing compilation with Boost, even if not found. This is needed when using a compiler wrapper, such as on Piz Daint, where Boost is not found by CMake, but the wrapper makes it available.
@jougs jougs merged commit 33870e6 into master Feb 3, 2020
@jougs
Copy link
Contributor

jougs commented Feb 3, 2020

🍾 🎈 🎉 💃 🕺

Many thanks and congratulations to all contributors, reviewers and testers! ❤️

@terhorstd terhorstd deleted the nest-3 branch April 15, 2020 10:14
@terhorstd terhorstd added I: Behavior changes Introduces changes that produce different results for some users S: Critical Needs to be addressed immediately T: Enhancement New functionality, model or documentation labels Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment